Skip to content

fix(benchmarks): adjust got after v15 upgrade#5526

Merged
mcollina merged 1 commit into
nodejs:mainfrom
slagiewka:benchmark_got
Jul 8, 2026
Merged

fix(benchmarks): adjust got after v15 upgrade#5526
mcollina merged 1 commit into
nodejs:mainfrom
slagiewka:benchmark_got

Conversation

@slagiewka

Copy link
Copy Markdown
Contributor

This relates to...

There are no benchmark results for got since ad29e7b.

Release notes: https://github.com/sindresorhus/got/releases/tag/v15.0.0

This addresses specifically the removed url and isStream parameters removed from the options object.

Status

There are no benchmark results for got since
ad29e7b.

Release notes: https://github.com/sindresorhus/got/releases/tag/v15.0.0

This addresses specifically the removed `url` and `isStream` parameters
removed from the options object.
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.44%. Comparing base (0dee09d) to head (1f9f80e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5526   +/-   ##
=======================================
  Coverage   93.44%   93.44%           
=======================================
  Files         110      110           
  Lines       37329    37329           
=======================================
  Hits        34883    34883           
  Misses       2446     2446           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 3c662a5 into nodejs:main Jul 8, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants